ai-workspace-services/qmd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't dispose llama in tests - let process exit handle cleanup

Browse Source 
The Metal backend crash happens regardless of whether we dispose or not.
It's a known llama.cpp issue during process exit static destructor cleanup:
https://github.com/ggml-org/llama.cpp/pull/17869

All 297 tests pass - the abort happens after tests complete.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Tobi Lutke 2025-12-21 13:42:38 -04:00
parent e8f4dce0b7
commit edc294db4f
No known key found for this signature in database
3 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/eval.test.ts
View File

@ -392,8 +392,7 @@ describe("Hybrid Search (RRF)", () => {
// Cleanup
// =============================================================================
afterAll(async () => {
// Dispose llama before process exit to properly free Metal resources
await disposeDefaultLlamaCpp();
afterAll(() => {
// Don't dispose llama - let process exit handle Metal cleanup naturally
rmSync(tempDir, { recursive: true, force: true });
});

9
src/llm.test.ts
View File

@ -12,6 +12,7 @@ import {
LlamaCpp,
getDefaultLlamaCpp,
setDefaultLlamaCpp,
disposeDefaultLlamaCpp,
type RerankDocument,
} from "./llm.js";
@ -20,9 +21,7 @@ import {
// =============================================================================
describe("Default LlamaCpp Singleton", () => {
afterAll(() => {
setDefaultLlamaCpp(null);
});
// Don't dispose - let process exit handle Metal cleanup naturally
test("getDefaultLlamaCpp creates instance on first call", () => {
setDefaultLlamaCpp(null);
@ -87,9 +86,7 @@ describe("LlamaCpp Integration", () => {
llm = new LlamaCpp();
});
afterAll(async () => {
await llm.dispose();
});
// Don't dispose - let process exit handle Metal cleanup naturally
describe("embed", () => {
test("returns embedding with correct dimensions", async () => {

4
src/mcp.test.ts
View File

@ -10,7 +10,7 @@ import { Database } from "bun:sqlite";
import * as sqliteVec from "sqlite-vec";
import { McpServer, ResourceTemplate } from "@modelcontextprotocol/sdk/server/mcp.js";
import { z } from "zod";
import { setDefaultLlamaCpp, LlamaCpp } from "./llm";
import { setDefaultLlamaCpp, disposeDefaultLlamaCpp, LlamaCpp } from "./llm";
import { mkdtemp, writeFile, readdir, unlink, rmdir } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
@ -225,7 +225,7 @@ describe("MCP Server", () => {
});
afterAll(async () => {
setDefaultLlamaCpp(null);
// Don't dispose llama - let process exit handle Metal cleanup naturally
testDb.close();
try {
require("fs").unlinkSync(testDbPath);