fix(docker.non_root): use numeric UID 65534 for K8s runAsNonRoot (#26268)
This commit is contained in:
parent
fb39683521
commit
c67d193400
@ -138,7 +138,7 @@ RUN mkdir -p /nonexistent /var/lib/litellm/assets /var/lib/litellm/ui && \
|
||||
[ -n "$LITELLM_PROXY_EXTRAS_PATH" ] && chmod -R g+w "$LITELLM_PROXY_EXTRAS_PATH" || true && \
|
||||
chmod -R g+rX "$PRISMA_PATH" /var/lib/litellm/ui /var/lib/litellm/assets /app/.cache
|
||||
|
||||
USER nobody
|
||||
USER 65534
|
||||
|
||||
RUN prisma generate --schema=./schema.prisma
|
||||
|
||||
|
||||
@ -2,7 +2,7 @@ schemaVersion: 2.0.0
|
||||
|
||||
metadataTest:
|
||||
entrypoint: ["docker/prod_entrypoint.sh"]
|
||||
user: "nobody"
|
||||
user: "65534"
|
||||
workdir: "/app"
|
||||
|
||||
fileExistenceTests:
|
||||
|
||||
54
tests/test_litellm/test_dockerfile_non_root.py
Normal file
54
tests/test_litellm/test_dockerfile_non_root.py
Normal file
@ -0,0 +1,54 @@
|
||||
"""
|
||||
Static checks on docker/Dockerfile.non_root.
|
||||
|
||||
The non_root image is intended for deployment into hardened Kubernetes
|
||||
clusters where `securityContext.runAsNonRoot: true` is enforced. The
|
||||
kubelet validates non-root status by parsing the image's USER field as
|
||||
an integer — a string name like "nobody" is rejected with
|
||||
CreateContainerConfigError because the kubelet cannot resolve
|
||||
/etc/passwd inside the image at admission time.
|
||||
"""
|
||||
|
||||
import os
|
||||
import re
|
||||
|
||||
import pytest
|
||||
|
||||
DOCKERFILE_PATH = os.path.join(
|
||||
os.path.dirname(__file__),
|
||||
"..",
|
||||
"..",
|
||||
"docker",
|
||||
"Dockerfile.non_root",
|
||||
)
|
||||
|
||||
|
||||
def _final_user_directive(dockerfile_text: str) -> str:
|
||||
"""Return the value of the last `USER` directive in the file."""
|
||||
matches = re.findall(r"^USER\s+(\S+)\s*$", dockerfile_text, re.MULTILINE)
|
||||
assert matches, "Dockerfile.non_root has no USER directive"
|
||||
return matches[-1]
|
||||
|
||||
|
||||
@pytest.mark.skipif(
|
||||
not os.path.exists(DOCKERFILE_PATH),
|
||||
reason="Dockerfile.non_root not present in this checkout",
|
||||
)
|
||||
def test_final_user_directive_is_numeric():
|
||||
"""The runtime USER must be a numeric UID so kubelet's runAsNonRoot
|
||||
admission check (strconv.Atoi) succeeds."""
|
||||
with open(DOCKERFILE_PATH, "r", encoding="utf-8") as f:
|
||||
contents = f.read()
|
||||
|
||||
final_user = _final_user_directive(contents)
|
||||
|
||||
assert final_user.isdigit(), (
|
||||
f"Dockerfile.non_root final USER is {final_user!r}; must be a numeric UID "
|
||||
"so Kubernetes' runAsNonRoot admission check can verify non-root status. "
|
||||
"See https://kubernetes.io/docs/tasks/configure-pod-container/security-context/"
|
||||
)
|
||||
|
||||
assert int(final_user) != 0, (
|
||||
f"Dockerfile.non_root final USER is {final_user} (root); the non_root image "
|
||||
"must run as a non-zero UID."
|
||||
)
|
||||
Loading…
Reference in New Issue
Block a user