fix: drop sensitive locals from re-raised error messages
Remove parameters that may contain credentials from the messages built inside broad except handlers. These messages can surface in HTTP error responses, so caller-supplied secrets and integration tokens shouldn't be interpolated into them.
This commit is contained in:
parent
9b3cd5ca25
commit
a291cc60cf
@ -88,7 +88,7 @@ class PromptManagementBase(ABC):
|
||||
messages = compiled_prompt_client["prompt_template"] + client_messages
|
||||
except Exception as e:
|
||||
raise ValueError(
|
||||
f"Error compiling prompt: {e}. Prompt id={prompt_id}, prompt_variables={prompt_variables}, client_messages={client_messages}, dynamic_callback_params={dynamic_callback_params}"
|
||||
f"Error compiling prompt: {e}. Prompt id={prompt_id}, prompt_variables={prompt_variables}, client_messages={client_messages}"
|
||||
)
|
||||
|
||||
compiled_prompt_client["completed_messages"] = messages
|
||||
@ -117,7 +117,7 @@ class PromptManagementBase(ABC):
|
||||
messages = compiled_prompt_client["prompt_template"] + client_messages
|
||||
except Exception as e:
|
||||
raise ValueError(
|
||||
f"Error compiling prompt: {e}. Prompt id={prompt_id}, prompt_variables={prompt_variables}, client_messages={client_messages}, dynamic_callback_params={dynamic_callback_params}"
|
||||
f"Error compiling prompt: {e}. Prompt id={prompt_id}, prompt_variables={prompt_variables}, client_messages={client_messages}"
|
||||
)
|
||||
|
||||
compiled_prompt_client["completed_messages"] = messages
|
||||
|
||||
@ -824,8 +824,6 @@ def convert_to_model_response_object( # noqa: PLR0915
|
||||
stream=stream,
|
||||
start_time=start_time,
|
||||
end_time=end_time,
|
||||
hidden_params=hidden_params,
|
||||
_response_headers=_response_headers,
|
||||
convert_tool_call_to_json_mode=convert_tool_call_to_json_mode,
|
||||
)
|
||||
raise Exception(
|
||||
|
||||
Loading…
Reference in New Issue
Block a user