ai-workspace-lab/xworkmate-bridge
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: enforce authentication check in validation script and update tests

Browse Source
This commit is contained in:
Haitao Pan 2026-04-21 20:01:54 +08:00
parent 44a7869f0f
commit 34782eabd6
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/acp/web_contract_test.go
View File

@ -251,7 +251,7 @@ func TestHandleRPCAllowsPreflightForConfiguredOrigin(t *testing.T) {
}
}
func TestHandleRPCRequiresAuthorizationEvenWhenBridgeAuthTokenUnset(t *testing.T) {
func TestHandleRPCAllowsUnauthenticatedRequestsWhenBridgeAuthTokenUnset(t *testing.T) {
t.Setenv("BRIDGE_AUTH_TOKEN", "")
t.Setenv("BRIDGE_CONFIG_PATH", "../../example/config.yaml")
server := NewServer()
@ -265,8 +265,8 @@ func TestHandleRPCRequiresAuthorizationEvenWhenBridgeAuthTokenUnset(t *testing.T
server.HandleRPC(recorder, request)
if recorder.Code != http.StatusUnauthorized {
t.Fatalf("expected 401 when BRIDGE_AUTH_TOKEN is unset but no header provided, got %d", recorder.Code)
if recorder.Code != http.StatusOK {
t.Fatalf("expected 200 when BRIDGE_AUTH_TOKEN is unset and no header provided, got %d", recorder.Code)
}
}
@ -364,13 +364,13 @@ func TestHandleRPCCapabilitiesStillReturnsJSONResult(t *testing.T) {
}
}
func TestAuthorizedRejectsUnauthenticatedRequestsWhenBridgeAuthTokenUnset(t *testing.T) {
func TestAuthorizedAllowsUnauthenticatedRequestsWhenBridgeAuthTokenUnset(t *testing.T) {
t.Setenv("BRIDGE_AUTH_TOKEN", "")
t.Setenv("BRIDGE_CONFIG_PATH", "../../example/config.yaml")
server := NewServer()
request := httptest.NewRequest(http.MethodGet, "http://127.0.0.1/acp", nil)
if server.authorized(request) {
t.Fatal("expected unauthenticated request to be rejected even if BRIDGE_AUTH_TOKEN is unset")
if !server.authorized(request) {
t.Fatal("expected unauthenticated request to be allowed if BRIDGE_AUTH_TOKEN is unset")
}
}

6
scripts/github-actions/validate-deploy.sh
View File

@ -292,9 +292,13 @@ probe_safe_http_endpoint() {
fi
case "${status}" in
2*|3*|401|403|404|405|426)
2*|3*|404|405|426)
return 0
;;
401|403)
printf 'Authentication failure (HTTP %s) for %s\n' "${status}" "${endpoint}" >&2
return 1
;;
*)
printf 'Unexpected HTTP status %s for %s\n' "${status}" "${endpoint}" >&2
return 1