From 6dd4437008afc34af7cb5ce7bfaacb211357cdde Mon Sep 17 00:00:00 2001
From: Haitao Pan <haitaopanhq@gmail.com>
Date: Tue, 30 Jun 2026 13:59:47 +0800
Subject: [PATCH] ci: remove unused remote_contract job from build-and-release
 workflow (#71)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The remote_contract job was effectively dead code — it only ran on
workflow_dispatch (excluded push and pull_request events) and was
configured with continue-on-error, so it never blocked releases.

Removing it simplifies the pipeline and eliminates the always()
workaround in the release job's if-condition.

Co-authored-by: Haitao Pan <manbuzhe2009@qq.com>
---
 .github/workflows/build-and-release.yml | 40 +------------------------
 1 file changed, 1 insertion(+), 39 deletions(-)

diff --git a/.github/workflows/build-and-release.yml b/.github/workflows/build-and-release.yml
index 184d4ed4..50a33082 100644
--- a/.github/workflows/build-and-release.yml
+++ b/.github/workflows/build-and-release.yml
@@ -305,46 +305,9 @@ jobs:
           path: ${{ matrix.artifact_paths }}
           if-no-files-found: error
 
-  remote_contract:
-    name: Test - remote provider contract
-    runs-on: ubuntu-22.04
-    needs:
-      - build
-    # Test-stage quality gate: runs between build and release.
-    # continue-on-error keeps it skippable so a failure never blocks release.
-    continue-on-error: true
-    if: ${{ github.event_name != 'push' && github.event_name != 'pull_request' }}
-    steps:
-      - name: Checkout source
-        uses: actions/checkout@v7
-
-      - name: Load Vault secrets
-        id: vault
-        uses: hashicorp/vault-action@v4
-        with:
-          url: ${{ env.VAULT_ADDR }}
-          method: jwt
-          role: github-actions-xworkmate-app
-          jwtGithubAudience: vault
-          ignoreNotFound: true
-          secrets: |
-            kv/data/github-actions/xworkmate-app REVIEW_ACCOUNT_LOGIN_PASSWORD | REVIEW_ACCOUNT_LOGIN_PASSWORD
-
-      - name: Export remote contract secrets
-        run: echo "REVIEW_ACCOUNT_LOGIN_PASSWORD=${{ steps.vault.outputs.REVIEW_ACCOUNT_LOGIN_PASSWORD }}" >> "$GITHUB_ENV"
-
-      - name: Verify accounts to bridge provider contract
-        shell: bash
-        env:
-          REVIEW_ACCOUNT_BASE_URL: ${{ vars.REVIEW_ACCOUNT_BASE_URL }}
-          REVIEW_ACCOUNT_LOGIN_NAME: ${{ vars.REVIEW_ACCOUNT_LOGIN_NAME }}
-        run: bash ./scripts/ci/verify_remote_provider_contract.sh
 
   release:
-    # always() so release waits for the remote_contract gate to finish but is
-    # never blocked by it being skipped (e.g. push events) or failing.
-    # build/prepare must still genuinely succeed.
-    if: ${{ always() && needs.prepare.outputs.should_release == 'true' && needs.prepare.result == 'success' && needs.build.result == 'success' }}
+    if: ${{ needs.prepare.outputs.should_release == 'true' && needs.prepare.result == 'success' && needs.build.result == 'success' }}
     strategy:
       fail-fast: false
       matrix:
@@ -367,7 +330,6 @@ jobs:
     needs:
       - prepare
       - build
-      - remote_contract
     steps:
       - name: Checkout source
         uses: actions/checkout@v7