From 3bc137be6b197f722aeddb4310a3b6c9153dfebd Mon Sep 17 00:00:00 2001 From: Haitao Pan Date: Fri, 5 Jun 2026 02:54:20 +0000 Subject: [PATCH] chore: add repomix-output.xml to .gitignore --- .gitignore | 1 + README.md | 10 ++++++++++ src/exportArtifacts.ts | 3 +-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index ff0a23e..a53345a 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ node_modules/ coverage/ *.tsbuildinfo +repomix-output.xml diff --git a/README.md b/README.md index 62f748e..9d18623 100644 --- a/README.md +++ b/README.md @@ -223,3 +223,13 @@ pnpm test pnpm typecheck pnpm pack:check ``` + +### Coding standards + +- **No unused exports.** Functions and types that are only used within the same file must not be exported. An `export` keyword signals a public API surface that downstream consumers may depend on. +- **No legacy fallback chains.** When renaming config keys or environment variables, remove the old name from the codebase. Multiple fallback paths to the same dependent service (e.g., two env vars for the same secret) create confusion and mask configuration errors. +- **No hardcoded model identifiers** (e.g., kimi-k2.5, minimax-m2.7, glm-5). Model selection must come from configuration or the bridge. +- **No silent error swallowing.** Every `catch` block must log, warn, rethrow, or return a meaningful fallback. Empty `catch` and `.catch(() => {})` are forbidden. +- **No redundant indirection.** If function A only calls B which only calls C with no added logic, inline or remove the middle function. +- **No stale config references.** Scripts in `package.json`, CI workflows, and documentation must reference only tooling that still exists in the project. +- **Multi-agent references** in bridge protocol parameters (`multiAgent: true`, `mode: "multi-agent"`) are legitimate protocol constants and are not dead code. However, framework-level ARIS or internal multi-agent orchestration code that duplicates bridge functionality must be removed. diff --git a/src/exportArtifacts.ts b/src/exportArtifacts.ts index ae2ef75..d128b68 100644 --- a/src/exportArtifacts.ts +++ b/src/exportArtifacts.ts @@ -355,7 +355,7 @@ export async function readXWorkmateArtifact(input: ReadInput): Promise): string return ( optionalString(pluginConfig.artifactRefSigningSecret) || optionalString(process.env.XWORKMATE_ARTIFACT_REF_SIGNING_SECRET) || - optionalString(process.env.XWORKMATE_ARTIFACT_DOWNLOAD_SIGNING_SECRET) || GENERATED_ARTIFACT_REF_SECRET ); }