ai-workspace-lab/codex-plugin-cc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: quote \$ARGUMENTS in cancel, result, and status commands (#168)

Browse Source 
Unquoted \$ARGUMENTS in the ! shell commands allowed shell metacharacters
in user-supplied job IDs to be expanded before Node received them (e.g.,
`task-123; malicious-cmd` would execute the trailing command). This is
inconsistent with review.md and adversarial-review.md, which both wrap
"$ARGUMENTS" in double quotes.

Co-authored-by: claude[bot] <claude-bot@anthropic.com>
Co-authored-by: Claude Code <noreply@anthropic.com>
This commit is contained in:
xiaolai 2026-04-09 05:48:50 +08:00 committed by GitHub
parent 8e9a38cdfe
commit 6a5c2ba53b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/codex/commands/cancel.md
View File

@ -5,4 +5,4 @@ disable-model-invocation: true
allowed-tools: Bash(node:*) allowed-tools: Bash(node:*)
--- ---
!`node "${CLAUDE_PLUGIN_ROOT}/scripts/codex-companion.mjs" cancel $ARGUMENTS` !`node "${CLAUDE_PLUGIN_ROOT}/scripts/codex-companion.mjs" cancel "$ARGUMENTS"`

2
plugins/codex/commands/result.md
View File

@ -5,7 +5,7 @@ disable-model-invocation: true
allowed-tools: Bash(node:*) allowed-tools: Bash(node:*)
--- ---
!`node "${CLAUDE_PLUGIN_ROOT}/scripts/codex-companion.mjs" result $ARGUMENTS` !`node "${CLAUDE_PLUGIN_ROOT}/scripts/codex-companion.mjs" result "$ARGUMENTS"`
Present the full command output to the user. Do not summarize or condense it. Preserve all details including: Present the full command output to the user. Do not summarize or condense it. Preserve all details including:
- Job ID and status - Job ID and status

2
plugins/codex/commands/status.md
View File

@ -5,7 +5,7 @@ disable-model-invocation: true
allowed-tools: Bash(node:*) allowed-tools: Bash(node:*)
--- ---
!`node "${CLAUDE_PLUGIN_ROOT}/scripts/codex-companion.mjs" status $ARGUMENTS` !`node "${CLAUDE_PLUGIN_ROOT}/scripts/codex-companion.mjs" status "$ARGUMENTS"`
If the user did not pass a job ID: If the user did not pass a job ID:
- Render the command output as a single Markdown table for the current and past runs in this session. - Render the command output as a single Markdown table for the current and past runs in this session.